Did you forgot change midi_win32.cpp?

Did you forgot change midi_win32.cpp?

I sure did. I’ll get that revised when I get a chance.

I have not tested the previous commit as I'm struggling to build this on Windows (I've never done Windows C++ development before and cannot figure out how to install SDL2.)

Can you either test that for me, or give me some help on how to install SDL2?

I had a look at the windows code. There are some issues.

#include <windows.h> needs to be lowercase (pre-existing issue)

midiInGetID(midi_handle, puDeviceId);
there I changed a case error at ID, and removed the '&' twice in the arguments. Otherwise it won't compile.

printf("Port[%u]: %s\n", i, puDeviceId);
Here you are trying to print an integer puDeviceId as if it is a string.

Maybe a helpful reference:
https://stackoverflow.com/questions/4384092/cannot-convert-int-to-lpunit

I had a look at the windows code. There are some issues.

#include <windows.h> needs to be lowercase (pre-existing issue)

midiInGetID(midi_handle, puDeviceId); there I changed a case error at ID, and removed the '&' twice in the arguments. Otherwise it won't compile.

printf("Port[%u]: %s\n", i, puDeviceId); Here you are trying to print an integer puDeviceId as if it is a string.

Thank you for looking into this! That means that I didn’t do what I had intended. I’m trying to print a named descriptor of the MIDI device (see the rtmidi implementation in this PR) to print out. All of Microsoft’s types are throwing me for a loop as someone unfamiliar with the win32 API.

It seems like to get a device name, I should have used this: https://learn.microsoft.com/en-us/windows/win32/api/mmeapi/nf-mmeapi-midiingetdevcaps

@Gerwin2k can you give me a tip on how to install SDL2? I’m using Visual Studio 2022 to build because I don’t know anything about the C++ build process on Windows (I’m only familiar with *nix systems). If you can point me to a better resource, I can use that instead.

I don't use any recent MSVC. Instead I use MinGW with Code::Blocks IDE.
if you do a web search "sdl2 msvc 2022" there are several setup guides.

Note that Nuked-SC55 already reports the Midi port description string in the console, but only for the single port that it is using.

Note that Nuked-SC55 already reports the Midi port description string in the console, but only for the single port that it is using.

I just committed a fix for my previous commit that copies the behavior of what you described. I'm still struggling to get MinGW running and won't have time to check this tonight, but since it's a copy/paste job, I imagine there shouldn't be an issue.

If nobody is free to check this today, I can get back to creating a Windows build environment tomorrow to check my work.

Thank you again for all your help!

With your recent change it works well. See attached screenshot.

With your recent change it works well. See attached screenshot.

That’s the behavior I expect! Thanks again for all of your help.

@graysonguarino a guide to compiling on Windows with Visual Studio: #44 (comment)